From: Nohemi Fernandez Date: Sun, 9 Oct 2011 20:24:59 +0000 (-0400) Subject: search: fix keyboard hiding when user starts a new search X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~7462 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=b9069df85c78b2f249742233ac2417ba94c9103f;p=gnome-shell.git search: fix keyboard hiding when user starts a new search The keyboard hides prematurely when the user is typing into an empty search box because the click is a captured event that triggers a loss of entry focus. By adding a keyboard check to this event, the problem is solved. https://bugzilla.gnome.org/show_bug.cgi?id=661340 --- diff --git a/js/ui/viewSelector.js b/js/ui/viewSelector.js index 4791d0bf1..2e3af18b7 100644 --- a/js/ui/viewSelector.js +++ b/js/ui/viewSelector.js @@ -289,9 +289,11 @@ SearchTab.prototype = { _onCapturedEvent: function(actor, event) { if (event.type() == Clutter.EventType.BUTTON_PRESS) { let source = event.get_source(); - if (source != this._text && this._text.text == '') { + if (source != this._text && this._text.text == '' && + !Main.layoutManager.keyboardBox.contains(source)) { // the user clicked outside after activating the entry, but - // with no search term entered - cancel the search + // with no search term entered and no keyboard button pressed + // - cancel the search this._reset(); } }